<html>
<head><meta charset="utf-8"><title>approve #62055 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html">approve #62055</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="168974697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/168974697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#168974697">(Jun 25 2019 at 20:34)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/62055" target="_blank" title="https://github.com/rust-lang/rust/pull/62055">https://github.com/rust-lang/rust/pull/62055</a> needs to be approved for backport quite quickly -- <span class="user-mention" data-user-id="116009">@nikomatsakis</span> <span class="user-mention" data-user-id="116083">@pnkfelix</span> any chance we could do that without full compiler team sign-off?</p>



<a name="168974736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/168974736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#168974736">(Jun 25 2019 at 20:34)</a>:</h4>
<p>I'd like to get the beta backport PR r+-ed tomorrow morning</p>



<a name="168975476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/168975476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#168975476">(Jun 25 2019 at 20:42)</a>:</h4>
<p>cc <span class="user-group-mention" data-user-group-id="492">@T-compiler</span>  more broadly</p>



<a name="168975568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/168975568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#168975568">(Jun 25 2019 at 20:44)</a>:</h4>
<p>We have a meeting on thursday, so will have to approve outside our process.</p>



<a name="168975656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/168975656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#168975656">(Jun 25 2019 at 20:44)</a>:</h4>
<p><span class="user-mention" data-user-id="123586">@nagisa</span>  Ideally async, in this thread? -- since you're here, maybe you can organize the yay/nay?</p>



<a name="168979349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/168979349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#168979349">(Jun 25 2019 at 21:31)</a>:</h4>
<p>I suspect rfcbot would be the way to go. But it also may not be worth the hassle; there are other beta nom’ed PR’s that I suspect are higher priority</p>



<a name="168979382"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/168979382" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#168979382">(Jun 25 2019 at 21:31)</a>:</h4>
<p>(I’m not really here, just weighing in before I go to bed....)</p>



<a name="168980565"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/168980565" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#168980565">(Jun 25 2019 at 21:47)</a>:</h4>
<p>Based on that it loosely sounds like maybe we're not likely to get acceptances then -- I might delay till tomorrow night with beta backport PR</p>



<a name="169011202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/169011202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#169011202">(Jun 26 2019 at 08:59)</a>:</h4>
<p>so, now that I'm back online: The particular PR that I was thinking was higher priority is PR <a href="https://github.com/rust-lang/rust/issues/67154" target="_blank" title="https://github.com/rust-lang/rust/issues/67154">#67154</a> (create a "provisional cache" to restore performance in the case of cycles)</p>



<a name="169011217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/169011217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#169011217">(Jun 26 2019 at 08:59)</a>:</h4>
<p>ah I now see that <span class="user-mention" data-user-id="116122">@simulacrum</span> already commented on it</p>



<a name="169012288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approve%20%2362055/near/169012288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approve.20.2362055.html#169012288">(Jun 26 2019 at 09:17)</a>:</h4>
<p>and then I retracted the nomination of PR <a href="https://github.com/rust-lang/rust/issues/62055" target="_blank" title="https://github.com/rust-lang/rust/issues/62055">#62055</a>.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>